-
ushindi bienvenu commented on merge request !61 at WikiSuite / Virtualmin Tiki Manager
()
This dependents on tikiwiki/tiki-manager!549 (merged) . It has been merged and for the same behavior to be reflected in virtualmin we need some progress here. Hope this will get attention asap
-
Ilia Ross commented on issue #11 at WikiSuite / WikiSuite Packages
()
I’ve just run a new series of tests and fixed several issues. The new WikiSuite Installer version 2.1.0 now works on all supported minimal clean distros. If you find any related bugs, open a new ticket first and discuss it internally. If Marc confirms the issue, assign it to me with a clear and concise bug description, and I will take care of it. The WikiSuite integration with the Virtualmin installer turned out to be very nice but also quite complicated. Example:
-
Ilia Ross closed issue #11: On a fresh install of Debian 12, the WikiSuite installer leads to "line 1: syntax error near unexpected token" at WikiSuite / Wik...
()
-
Ilia Ross pushed to project branch main at WikiSuite / WikiSuite Packages
()
Ilia Ross (aab86970) at 01 May 14:06 2.1.0 ... and 4 more commits
-
Ilia Ross pushed to project branch main at WikiSuite / WikiSuite Packages
()
Ilia Ross (dbea22ec) at 01 May 12:39 Added wikisuite-php8.5 with dependencies on the matching php8.5-* p...
-
Ilia Ross pushed to project branch main at WikiSuite / WikiSuite Packages
()
Ilia Ross (e6b889c5) at 01 May 12:20 PHP 8.5 is out
-
Joseph Lwanzo Kausi commented on merge request !87 at WikiSuite / WikiSuite Packages
()
On the whitespace point: what appears as extra space is actually a tab delimiter used by Virtualmin template syntax, so I kept it unchanged for consistency with the existing templates. On the second point: php_admin_value[disable_functions] and php_admin_value[allow_url_fopen] are intentionally kept in the same php_fpm= value and separated by tabs, because in these template files tabs represent line breaks/directive separation when Virtualmin generates the final PHP-FPM pool config. So no functional change is needed here, and this keeps the same structure as the other templates.
-
Joseph Lwanzo Kausi commented on merge request !87 at WikiSuite / WikiSuite Packages
()
@luciash ,Yes, I understand that there is a code formatting standard to follow. My issue is that I’m not able to test it with a real installation. The main reasons are: I tried to set up the full packaging and repository workflow to reproduce a real installation scenario I’m using two servers (lab32 for installation and lab33 for the APT repository) Although I managed to build the packages and generate the repository, the full installation process did not succeed I’m facing dependency resolution issues I haven’t yet been able to complete a successful end-to-end test
-
Joseph Lwanzo Kausi commented on merge request !87 at WikiSuite / WikiSuite Packages
()
@luciash, Yes, it was done just for testing purposes. I prefer to test with the changes I made on the Tiki Manager repository in my specific branch, to make sure everything works before taking the repository out of draft mode.
-
luci commented on merge request !87 at WikiSuite / WikiSuite Packages
()
@Grandi0z Looks good but the white space added after $HOME/tmp is not needed, right? And php_admin_value[disable_functions] and php_admin_value[allow_url_fopen] should be on new line perhaps?