-
Ilia Ross pushed to project branch main at WikiSuite / WikiSuite Packages
()
Ilia Ross (0c550552) at 24 Nov 17:55 Merge branch 'add-etckeeper' into 'main' ... and 1 more commit
-
Ilia Ross accepted merge request !72: [ENH] add etckeeper to run before and after wikisuite-installer run at WikiSuite / WikiSuite Packages
()
-
Ilia Ross commented on merge request !72 at WikiSuite / WikiSuite Packages
()
Ah, okay. I see now! Thanks! Merging it now. I think we should now figure out how to integrate this into the TikiWiki Installer and whether it should be enabled by default.
-
Elvis Ansima commented on merge request !72 at WikiSuite / WikiSuite Packages
()
@iliajie , when ERROR has a column, a comma is way better.
-
Ilia Ross commented on merge request !72 at WikiSuite / WikiSuite Packages
()
In the first error message, there’s a comma before the error output, while in the second, there’s a colon? Thanks! But why did you decide to choose , over :?
-
Ilia Ross commented on merge request !72 at WikiSuite / WikiSuite Packages
()
Thanks! In the first error message, there’s a comma before the error output, while in the second, there’s a colon?
-
Elvis Ansima commented on merge request !72 at WikiSuite / WikiSuite Packages
()
Thanks for the tip @iliajie shellcheck really helped
-
Ilia Ross commented on merge request !72 at WikiSuite / WikiSuite Packages
()
$arg should be quoted here. Also, you might want to run shellcheck on your script — ${$VAR} is definitely a bug.
-
Ilia Ross commented on merge request !72 at WikiSuite / WikiSuite Packages
()
Not likely on a server, probably i should remove that case? Yeah, it should always be set.
-
Elvis Ansima commented on merge request !72 at WikiSuite / WikiSuite Packages
()
Not likely on a server, probably i should remove that case?